Skip to content

Rule for checking a dynamic call on static methods #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rule for checking a dynamic call on static methods #5

wants to merge 1 commit into from

Conversation

lookyman
Copy link
Contributor

Closes #4

@lookyman lookyman force-pushed the dynamic-call-on-static-method branch from 41d0fda to 3fc72b4 Compare December 27, 2017 21:57
@lookyman lookyman force-pushed the dynamic-call-on-static-method branch from 3fc72b4 to bb3f543 Compare December 27, 2017 22:14
@ondrejmirtes
Copy link
Member

Merged as 2091311, thanks!

Changes:

  • Rebased on master, fixed PHP 7.1 stuff (added void return typehints)
  • Removed $scope->canCallMethod() so that the user can find out all the mistakes at once.
  • Added testcases without an error to test the happy path.

@ondrejmirtes ondrejmirtes mentioned this pull request Dec 28, 2017
Closed
@Majkl578
Copy link
Contributor

@lookyman Thanks for this!
PHPUnit, brace yourself! :trollface:

@Majkl578 Majkl578 mentioned this pull request Jan 31, 2018
Merged
@agentrickard agentrickard mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookyman @ondrejmirtes @Majkl578